Raise a CompilationError for unknown rules#445
Merged
Conversation
timostamm
commented
Mar 23, 2026
protovalidate/internal/rules.py
Outdated
| import celpy | ||
| from celpy import celtypes | ||
| from google.protobuf import any_pb2, descriptor, duration_pb2, message, message_factory, timestamp_pb2 | ||
| from google.protobuf import any_pb2, descriptor, duration_pb2, message, message_factory, timestamp_pb2, unknown_fields # type: ignore[attr-defined] |
Member
Author
There was a problem hiding this comment.
From what I can see, this API (google.protobuf.unknown_fields) was added in 4.21.0.
There are no stubs in types-protobuf though.
Member
There was a problem hiding this comment.
unfortunately doesn't look like it's registered upstream either: https://github.com/search?q=repo%3Apython%2Ftypeshed%20unknown_fields&type=code. Upstream impl: https://github.com/protocolbuffers/protobuf/blob/main/python/google/protobuf/unknown_fields.py.
stefanvanburen
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new field rule is added to validate.proto, implementations need to update to support it. If the implementation is not updated to support the rule, it may silently pass an invalid message with a new rule.
All other implementations of Protovalidate raise an error if they encounter an unknown rule. This PR adds the same functionality to protovalidate-python.