Show sign here label and a line in the background#160
Show sign here label and a line in the background#160JianxunSu wants to merge 1 commit intobrinley:masterfrom
Conversation
To make signhere label and a reference line displayed in the background as a svg, this could be alternative to the original Sign Here sticker.
brinley
left a comment
There was a problem hiding this comment.
Not sure what is the reason for your change? Why do you need the sign here image in the background? do you need it to persist there? As for the signature line, I get why you would want to put in the background, however the better spot would be to add a flag in jSignature core itself to toggle between background signature line and canvas line (i believe https://github.com/brinley/jSignature/blob/master/src/jSignature.js#L999)
|
Thanks for your explanation, I didn't notice there is a signature line function exist in core, yes I agree with you that's a better solution. For the sigh here image in the background, this is just a project requirement. I think it needn't to be that in most cases, so this is just an initial work as a reference. |
|
Would you like to update the core itself with your feature? |
|
Sorry to reply late, I m not sure, currently don't have enough time for this, maybe will do it in the future.. |
To make signhere label and a reference line displayed in the background as a svg, this could be alternative to the original Sign Here sticker.