Skip to content

Lynga loader read for Pull Request#392

Open
casazza wants to merge 1 commit intobrickbots:mainfrom
casazza:lynga-pr
Open

Lynga loader read for Pull Request#392
casazza wants to merge 1 commit intobrickbots:mainfrom
casazza:lynga-pr

Conversation

@casazza
Copy link

@casazza casazza commented Mar 4, 2026

Lynga Open Cluster Catalog loader.
Unit tests needed change to allow for 1 object at a Dec or exactly 0.0

@mrosseel
Copy link
Collaborator

mrosseel commented Mar 5, 2026

looks good at first glance.
The location in the menu should be changed I think, should be where the Harris catalog is, it seems it's now in the top menu (maybe for testing).
If you keep on producing catalogs we'll probably need to subdivide the menus a bit further into open clusters, globulars, etc. We'll cross that bridge when we get there :).

@casazza
Copy link
Author

casazza commented Mar 6, 2026

@mrosseel I added it in alphabetical order in the DSOs list. That feels most correct as everything else was in alphabetic order. Are you seeing something different?

I do agree that we are getting a number of catalogs and should revisit the order.

@brickbots
Copy link
Owner

Fantastic @casazza ! Thank you again for another great catalog addition. Did you happen to have a bead on the usage/license for this? I didn't see this in the readme and I tried to check the source URL and it looks like the server is down.

@casazza
Copy link
Author

casazza commented Mar 6, 2026

@brickbots This was free to use. No special notification or attribution required. I added it to the Catalog's doc. That should be more than sufficient.

return designation, is_official


def identify_catalog_type(name: str) -> Tuple[bool, str]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are already common facilities to find if something is in our database called ObjectFinder, so maybe you can use those for this use case? Or extend them / add a utility function if you have a unique use case

@mrosseel
Copy link
Collaborator

just have a look at that one remark I gave but for the rest it looks good, haven't tested it locally yet though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants