Implementation of Wacongne et al. 2012 paper with using Brian2.#1767
Implementation of Wacongne et al. 2012 paper with using Brian2.#1767cagataydisli wants to merge 5 commits intobrian-team:masterfrom
Conversation
Co-authored-by: AtakanDogan21 <AtakanDogan21@users.noreply.github.com>
|
Hi @cagataydisli and @AtakanDogan21, thank you for your PR (and apologies for not replying timely on the previous one)! This is a big example, and I did not yet have time to look into it in detail, but it also makes me wonder whether the inclusion in the documentation is actually the best format for such an example. Historically, "from_paper" examples were single-file scripts, and multi-file examples were mostly about generating one figure per file. Your structure makes certainly sense (from the very cursory look I had, at least), but it will not be obvious to use from the documentation (e.g. you cannot download all files at once). I wonder whether it would not make more sense to have a link to a separate repository or something similar in such cases. I'll raise this issue on the discourse forum, let's see what others think. So in sum, thanks again, complex examples like this are much appreciated, but I am putting this PR "on hold" for now until we decide what the best approach for including it into Brian's documentation is. PS: I think for copyright reasons, you should remove the paper PDF from the PR – we wouldn't include it in the documentation, in any case. |
Me (@cagataydisli) and my friend (@AtakanDogan21) have implemented Wacongne's 2012 paper about Predictive Coding and Mismatch Negativity. We want to contrubute to the Brian2 documantation.