Skip to content

Use pretty-print formatting for error messages #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parker Henderson (parkerhendo) merged 1 commit into from
Mar 21, 2026
Merged

Use pretty-print formatting for error messages #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/functions/push.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ async fn push_file(
let bundle = validate_python_bundle(manifest_file, source_path, allowed_roots)
.map_err(|err| FileFailure {
reason: HardFailureReason::ManifestSchemaInvalid,
message: err.to_string(),
message: format!("{err:#}"),
})?;
let archive = build_python_bundle_archive(
&bundle.entry_module,
Expand All @@ -786,7 +786,7 @@ async fn push_file(
)
.map_err(|err| FileFailure {
reason: HardFailureReason::BundleUploadFailed,
message: err.to_string(),
message: format!("{err:#}"),
})?;
(archive, None)
}
Expand All @@ -801,14 +801,14 @@ async fn push_file(
.await
.map_err(|err| FileFailure {
reason: HardFailureReason::UploadSlotFailed,
message: err.to_string(),
message: format!("{err:#}"),
})?;

api::upload_bundle(&slot.url, upload_bytes, content_encoding)
.await
.map_err(|err| FileFailure {
reason: HardFailureReason::BundleUploadFailed,
message: err.to_string(),
message: format!("{err:#}"),
})?;

bundle_id = Some(slot.bundle_id.clone());
Expand Down Expand Up @@ -876,7 +876,7 @@ async fn push_file(
collect_project_name_placeholders_checked(&event, &mut placeholders).map_err(|err| {
FileFailure {
reason: HardFailureReason::ManifestSchemaInvalid,
message: err.to_string(),
message: format!("{err:#}"),
}
})?;

Expand All @@ -893,7 +893,7 @@ async fn push_file(
.await
.map_err(|err| FileFailure {
reason: HardFailureReason::ManifestSchemaInvalid,
message: err.to_string(),
message: format!("{err:#}"),
})?;
resolved_placeholders.insert(project_name, resolved);
}
Expand Down Expand Up @@ -970,7 +970,7 @@ fn build_js_bundle(
) -> std::result::Result<Vec<u8>, FileFailure> {
let build_dir = TempBuildDir::create("bt-functions-js-bundle").map_err(|err| FileFailure {
reason: HardFailureReason::BundleUploadFailed,
message: err.to_string(),
message: format!("{err:#}"),
})?;
let output_bundle = build_dir.path.join("bundle.js");

Expand Down Expand Up @@ -1368,7 +1368,7 @@ fn validate_manifest_paths(
if language == SourceLanguage::Python && has_code_entries {
validate_python_bundle(file, &path, allowed_roots).map_err(|err| FileFailure {
reason: HardFailureReason::ManifestSchemaInvalid,
message: err.to_string(),
message: format!("{err:#}"),
})?;
}
seen.insert(path);
Expand Down
Loading