feat(google_genai): Instrument embed_content methods#111
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 3 commits intomainfrom
Open
feat(google_genai): Instrument embed_content methods#111Abhijeet Prasad (AbhiPrasad) wants to merge 3 commits intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 3 commits intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
requested a review
from ViaDézo1er / cedric (viadezo1er)
…ct that It should allow the CI to pass
ViaDézo1er / cedric (viadezo1er)
approved these changes
Mar 20, 2026
Contributor
|
Though maybe review my commits before merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #105
This PR adds instrumentation for
client.models.embed_content()andclient.aio.models.embed_content(). It also adds tests accordingly.While I was working on this, I refactored all the wrapper helpers to be a common set of utilities, which should make this much easier to maintain and work with.