fix: warn when Eval() receives an empty dataset#109
Merged
eric kontargyris (ekon15) merged 3 commits intomainfrom Mar 21, 2026
Merged
fix: warn when Eval() receives an empty dataset#109eric kontargyris (ekon15) merged 3 commits intomainfrom
eric kontargyris (ekon15) merged 3 commits intomainfrom
Conversation
Print a warning to stderr when no data rows are found after iterating the dataset, so users get an actionable signal instead of silently landing on an empty experiment in the UI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
py/src/braintrust/framework.py
Outdated
| tasks.append(asyncio.create_task(with_max_concurrency(run_evaluator_task(datum, trial_index)))) | ||
|
|
||
| if not tasks: | ||
| print( |
There was a problem hiding this comment.
Can we switch this to use eprint? We might also want to use bcolors.WARNING.
Contributor
Author
There was a problem hiding this comment.
Done — switched to eprint with bcolors.WARNING.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 20, 2026
Abhijeet Prasad (AbhiPrasad)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_evaluatoriterates zero data rowsTest plan
test_run_evaluator_empty_dataset_warns— asserts warning appears in stderr whendata=[]test_framework.pytests unaffected🤖 Generated with Claude Code