Skip to content

Use async flag in logs3 #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ankur Goyal (ankrgyl) wants to merge 11 commits into from
+2 −2
Closed

Use async flag in logs3 #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e10093
use async flag in logs3
ankrgyl Apr 11, 2025
7344e73
Merge branch 'main' into logs3-async
ankrgyl Apr 17, 2025
081bfac
Merge branch 'main' into logs3-async
ankrgyl Apr 21, 2025
bbb7fcc
Merge branch 'main' into logs3-async
ankrgyl Apr 25, 2025
7d30be3
Merge branch 'main' into logs3-async
ankrgyl May 4, 2025
5d20119
Merge branch 'main' into logs3-async
ankrgyl May 7, 2025
1ee35df
Merge branch 'main' into logs3-async
ankrgyl May 14, 2025
cc5665d
Merge branch 'main' into logs3-async
ankrgyl May 15, 2025
ea4cf6d
Merge branch 'main' into logs3-async
ankrgyl May 21, 2025
0021adf
Merge branch 'main' into logs3-async
ankrgyl Jun 6, 2025
e60de98
Merge branch 'main' into logs3-async
ankrgyl Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1893,7 +1893,7 @@ function castLogger<ToB extends boolean, FromB extends boolean>(
}

function constructLogs3Data(items: string[]) {
return `{"rows": ${constructJsonArray(items)}, "api_version": 2}`;
return `{"rows": ${constructJsonArray(items)}, "api_version": 2, "async": true}`;
}

function now() {
Expand Down
2 changes: 1 addition & 1 deletion py/src/braintrust/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ def construct_json_array(items: Sequence[str]):

def construct_logs3_data(items: Sequence[str]):
rowsS = construct_json_array(items)
return '{"rows": ' + rowsS + ', "api_version": ' + str(DATA_API_VERSION) + "}"
return '{"rows": ' + rowsS + ', "api_version": ' + str(DATA_API_VERSION) + ', "async": true}'


def _check_json_serializable(event):
Expand Down
Loading