fix: APIPromise workaround in bundlers#1623
Merged
Stephen Belanger (Qard) merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad),
bradumbaugh and
Luca Forstner (lforst)
Member
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
can we add a regression test somehow?
Stephen Belanger (Qard)
force-pushed
the
bundled-api-promise-fix
branch
from
ef7919c to
c28c59e
Compare
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 20, 2026
Member
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
wow anthropic is so annoying with this non standard behaviour. I don't even understand why they need to do it either.
Abhijeet Prasad (AbhiPrasad)
changed the title
Stephen Belanger (Qard)
force-pushed
the
bundled-api-promise-fix
branch
3 times, most recently
from
5fc9174 to
1c48542
Compare
Stephen Belanger (Qard)
force-pushed
the
bundled-api-promise-fix
branch
from
1c48542 to
5cce8ad
Compare
Auto-instrumented spans now produce context:{} instead of
context:{caller_filename:"<node-internal>",...} because patchTracingChannel
is bundled into index.mjs alongside getCallerLocation. When all stack
frames share the same directory, getCallerLocation returns undefined.
The <node-internal> value was an artifact of the native C++ tracePromise
call stack, not meaningful user code location info.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.