fix: Preserve OpenAI return values#1618
Open
Luca Forstner (lforst) wants to merge 4 commits intomainfrom
Open
Conversation
# Conflicts: # e2e/scenarios/openai-auto-instrumentation-node-hook/__snapshots__/scenario.test.ts.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI methods that return helper promise objects are now instrumented without collapsing them into plain promises.
The hook now preserves the original OpenAI helper behavior while still tracing the eventual result.
The openai auto-hook e2e scenario was switched back to the real helper APIs instead of falling back to lower-level create calls.
Why
The previous hook path broke API compatibility by stripping OpenAI helper behavior in auto-instrumented mode.
That made valid OpenAI code fail only when Braintrust auto-instrumentation was enabled.
Fixes #1592