fix: wire upstream and watch/triage commands in cli-entry.ts#280
Merged
bradygaster merged 2 commits intobradygaster:mainfrom Mar 8, 2026
Merged
Conversation
tamirdresher
force-pushed
the
fix/rewire-upstream-watch
branch
2 times, most recently
from
c9f3caa to
8ff8654
Compare
Both commands had full implementations (upstream.ts, watch.ts) but were not routed in cli-entry.ts — the recurring 'unwired command' bug class (issues bradygaster#224, bradygaster#236, bradygaster#237). - upstream: add import + routing block for upstreamCommand() - triage/watch: replace placeholder stub with actual runWatch() call - help text: add upstream command description - test: clear KNOWN_UNWIRED set (all commands now wired) Root cause: Brady's cli-entry.ts rewrite (v0.8.21-0.8.23) overwrote the wiring added in PRs bradygaster#225 and bradygaster#238. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
force-pushed
the
fix/rewire-upstream-watch
branch
from
8ff8654 to
3c762d4
Compare
Tests that read live .squad/team.md and .squad/routing.md were hardcoding agent names (Fenster, Keaton, Hockney). Every time Brady renames the squad (e.g., Usual Suspects → Apollo 13), these tests break. Fixed by making live-file tests assert structure and behavior, not names: - parseRoster(): verify properties exist, not specific member names - parseRoutingRules(): verify structure, emoji presence, not agent strings - parseModuleOwnership(): verify shape, not which agent owns which module - triageIssue(): verify source/confidence, not which agent was selected Tests with inline fixtures (hardcoded test data) still assert specific names — those are self-contained and don't break on rebirths. Also bumps speed-gates line count budget for upstream help text. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
force-pushed
the
fix/rewire-upstream-watch
branch
from
3c762d4 to
619e06d
Compare
Owner
|
i am sorry! |
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both upstream and watch/triage commands had full implementations but were not routed in cli-entry.ts - the recurring unwired command bug class (issues #224, #236, #237).
What changed
Root cause
Brady's cli-entry.ts rewrite (v0.8.21-0.8.23) overwrote the routing added in merged PRs #225 and #238. The command implementations survived (they're in separate files), but the routing was lost.
Testing
Fixes squad upstream and squad watch/squad triage commands for the next release.