Conversation
test/spec/.eslintrc
Outdated
| @@ -1,2 +1,2 @@ | |||
| env: | |||
| mocha: true | |||
| jest: true | |||
There was a problem hiding this comment.
use the overrrides feature of the root .eslintrc for this
https://github.com/10xjs/form/blob/master/.eslintrc#L7
| export {default as reducer} from './reducer'; | ||
| export {default} from './connect'; | ||
| // @flow | ||
| export {default} from './createRelocation'; |
There was a problem hiding this comment.
Remove this redundant file to cut down on bundle-size. or use rollup
There was a problem hiding this comment.
I think at this point it's so tiny as to be a non-issue. But a good point nonetheless.
| // eslint-disable-next-line | ||
| UNSAFE_componentWillMount() { | ||
| this.props.addChild(this.id, this.props.children, this.props.meta); | ||
| } |
There was a problem hiding this comment.
use componentDidMount, and componentDidUpdate to handle side-effects (see: reactjs/rfcs#26)
Hopefully we can use these instead of the lifecycle funcs that are on the chopping block.
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
===========================================
+ Coverage 83.67% 95.65% +11.97%
===========================================
Files 5 1 -4
Lines 49 46 -3
Branches 8 2 -6
===========================================
+ Hits 41 44 +3
+ Misses 8 2 -6
Continue to review full report at Codecov.
|
Change
relocationto use the context API available inreact^16.3. This makes portals much more "declarative". Instead of dispatching an action you mount/render a component.First create an instance:
Then wrap your app in a provider:
Then have a place to consume generated components somewhere:
Then dispatch components into the aforementioned containers:
/cc @10xjs