Open
Conversation
Clang with libc++ and -std=c++23 fails to compile with:
error: no member named 'terminate' in namespace 'std'; did you mean 'template'?
This change ensures the definition of std::terminate() is available for this scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang with libc++ and -std=c++23 fails to compile with:
This change ensures the definition of
std::terminate()is available for this scenario by adding the relevant include.Steps to reproduce on a mac:
cat test.cppSide note: It may be worth noting that this did work for earlier versions of the c++ standard. For instance,
-std=c++20works fine. So this might have to do with some of theconstexprchanges in c++23 which can cause earlier evaluation of templates.This fix addresses issue #139.