feat: Prefix keys with strategy name by nssherpa · Pull Request #129 · block/cachew

nssherpa · 2026-02-19T23:37:48Z

Testing

Per strategy name directory in the cache folder

Every 1.0s: curl -s http://localhost:8080/api/v1/stats | jq                                                                                                             BLKL5XW75Q41X.local: Thu Feb 19 20:28:34 2026
                                                                                                                                                                                                        in 0.058s (0)
{
  "objects": 5,
  "size": 3055418,
  "capacity": 5242880
}

nssherpa · 2026-02-20T04:31:50Z

internal/cache/disk.go

+	c := *d
+	c.namespace = namespace
+	return &c
+}


Lmk if this is how you were thinking to have the same underlying cache and inject the namespace from the registry.

Yep this seems like the cleanest way!

alecthomas · 2026-02-20T04:37:19Z

cmd/cachew/main.go

-	Put    PutCmd    `cmd:"" help:"Upload object to cache." group:"Operations:"`
-	Delete DeleteCmd `cmd:"" help:"Remove object from cache." group:"Operations:"`
+	URL       string `help:"Remote cache server URL." default:"http://127.0.0.1:8080"`
+	Namespace string `help:"Namespace for organizing cache objects." default:""`


Do you think this should be a positional arg in each subcommand instead? Or if not, it should have a short flag so it's easy to use.

Subcommand:

cachew get <namespace> <key>

Flag:

cachew -n <namespace> get <key>

I feel like 99% of the time you're going to need a namespace, so the former is probably preferable.

alecthomas · 2026-02-20T04:37:35Z

cmd/cachew/main.go

+	Stat           StatCmd           `cmd:"" help:"Show metadata for cached object." group:"Operations:"`
+	Put            PutCmd            `cmd:"" help:"Upload object to cache." group:"Operations:"`
+	Delete         DeleteCmd         `cmd:"" help:"Remove object from cache." group:"Operations:"`
+	ListNamespaces ListNamespacesCmd `cmd:"" help:"List available namespaces in cache." group:"Operations:"`


Rename this to Namespaces.

Suggested change

ListNamespaces ListNamespacesCmd `cmd:"" help:"List available namespaces in cache." group:"Operations:"`

Namespaces ListNamespacesCmd `cmd:"" help:"List available namespaces in cache." group:"Operations:"`

alecthomas · 2026-02-20T04:39:20Z

internal/cache/disk.go

+	if err := d.db.deleteAll(sizeEvictedEntries); err != nil {
+		return errors.Errorf("failed to delete size-evicted metadata: %w", err)


Should this call deleteExpiredEntries like the other one?

alecthomas · 2026-02-20T04:39:51Z

internal/cache/disk.go

+	c := *d
+	c.namespace = namespace
+	return &c
+}


Yep this seems like the cleanest way!

alecthomas · 2026-02-20T04:44:02Z

internal/cache/disk_metadb.go

+		}
+
+		namespaceBucket := tx.Bucket(namespaceBucketName)
+		return errors.WithStack(namespaceBucket.Put(dbKey, []byte(namespace)))


It's not clear to me why we need this extra bucket? AFAICT it's basically storing <namespace>/<sha> -> <namespace> but if we have the namespace in the key, we can just extract it?

OTOH a <namespace> -> true mapping might be useful, though we could probably just keep that in memory computed from the initial walk, as the number of namespaces is never going to be very high.

alecthomas · 2026-02-20T04:45:51Z

internal/cache/disk_metadb.go

+			var key Key
+
+			// Check format: composite "namespace/hexkey" or raw 32-byte key
+			slashIdx := bytes.IndexByte(k, '/')


Using bytes.Cut(k, []byte("/")) would replace most of this switch here.

alecthomas · 2026-02-20T04:47:30Z

internal/cache/disk_namespace_test.go

+func TestDiskNamespaceIsolation(t *testing.T) {
+	dir := t.TempDir()
+	_, ctx := logging.Configure(t.Context(), logging.Config{Level: slog.LevelDebug})
+
+	// Create base cache
+	baseCache, err := cache.NewDisk(ctx, cache.DiskConfig{
+		Root:   dir,


Namespace tests should be moved into the cachetest suite so that it tests namespacing uniformly across all implementations.

alecthomas · 2026-02-20T04:57:02Z

internal/cache/remote.go

+// Namespace creates a namespaced view (which is ignored by remote cache).
+// Remote cache ignores namespaces since the server-side API v1 handles namespacing.
+func (c *Remote) Namespace(_ string) Cache {
+	// Remote cache doesn't use namespacing on client side


Is this true? How else would the namespace get conveyed to the server?

alecthomas · 2026-02-20T04:58:10Z

internal/cache/tiered.go

+	for ns := range namespaceSet {
+		namespaces = append(namespaces, ns)
+	}
+	return namespaces, nil


Always good to stablesort values out of a map so tests don't become flaky.

alecthomas · 2026-02-20T04:59:36Z

internal/strategy/apiv1.go

@@ -37,6 +37,7 @@ func NewAPIV1(ctx context.Context, _ struct{}, cache cache.Cache, mux Mux) (*API
 	mux.Handle("POST /api/v1/object/{key}", http.HandlerFunc(s.putObject))


It doesn't look like namespaces get through to the server in any way?

Suggested change

mux.Handle("POST /api/v1/object/{key}", http.HandlerFunc(s.putObject))

mux.Handle("POST /api/v1/object/{namespace}/{key}", http.HandlerFunc(s.putObject))

nssherpa force-pushed the nsherpa/s3-strategy-prefix branch from d02b0ff to 2fd1efb Compare February 19, 2026 23:38

feat: Prefix keys with strategy name

95058ce

nssherpa force-pushed the nsherpa/s3-strategy-prefix branch 4 times, most recently from 8cc22b8 to 3935ba2 Compare February 20, 2026 02:27

fix: Update the api with namespace

fabab8e

nssherpa force-pushed the nsherpa/s3-strategy-prefix branch 3 times, most recently from 63232fe to c7ba70b Compare February 20, 2026 04:08

fix: Add composite key with namespace to disk_metadatadb

9c72769

nssherpa force-pushed the nsherpa/s3-strategy-prefix branch from c7ba70b to 9c72769 Compare February 20, 2026 04:23

nssherpa marked this pull request as ready for review February 20, 2026 04:28

nssherpa requested a review from a team as a code owner February 20, 2026 04:28

nssherpa requested review from alecthomas and removed request for a team February 20, 2026 04:28

nssherpa commented Feb 20, 2026

View reviewed changes

alecthomas reviewed Feb 20, 2026

View reviewed changes

	ListNamespaces ListNamespacesCmd `cmd:"" help:"List available namespaces in cache." group:"Operations:"`
	Namespaces ListNamespacesCmd `cmd:"" help:"List available namespaces in cache." group:"Operations:"`

		if err := d.db.deleteAll(sizeEvictedEntries); err != nil {
		return errors.Errorf("failed to delete size-evicted metadata: %w", err)

		@@ -37,6 +37,7 @@ func NewAPIV1(ctx context.Context, _ struct{}, cache cache.Cache, mux Mux) (*API
		mux.Handle("POST /api/v1/object/{key}", http.HandlerFunc(s.putObject))

	mux.Handle("POST /api/v1/object/{key}", http.HandlerFunc(s.putObject))
	mux.Handle("POST /api/v1/object/{namespace}/{key}", http.HandlerFunc(s.putObject))

Conversation

nssherpa commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

nssherpa commented Feb 19, 2026 •

edited

Loading