fix(sessions): dedupe streamed tool calls with deterministic upserts#223
Merged
fix(sessions): dedupe streamed tool calls with deterministic upserts#223
Conversation
Revert the SessionModal tool-call dedupe heuristic from aa7ed57 so the UI reflects raw message rows again. Handle streamed ACP updates in the backend writer by updating existing rows instead of inserting duplicates: repeated tool_call IDs now update the same tool_call row, and repeated tool_result chunks update a single tool_result row. Add an ACP stream probe example (src-tauri/examples/acp_stream_probe.rs) to run codex-acp and print tool-call/tool-result event patterns and duplicate ID counts for debugging. Also add writer unit tests covering both behaviors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary