fix: make repo and project deletion async to prevent UI freezing#216
Merged
fix: make repo and project deletion async to prevent UI freezing#216
Conversation
Move heavy I/O work (worktree removal, remote workspace deletion, directory cleanup) off the main thread using spawn_blocking in both remove_project_repo and delete_project Tauri commands. - Convert remove_project_repo from sync fn to async fn, wrapping cleanup_branch_resources calls in spawn_blocking - Wrap delete_project's cleanup_branch_resources_best_effort loop and filesystem cleanup in spawn_blocking (was async but still blocking) - Frontend already has spinner UI in place: BranchCard shows a 'Deleting...' overlay via deletingBranches state, and project deletion uses deletingProjectNames with toast notifications Follows the same pattern used by delete_branch in branches.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move heavy cleanup operations (worktree removal, remote workspace deletion, directory cleanup) in
remove_project_repoanddelete_projecttospawn_blockingtasks so the UI thread stays responsive when deleting large repos or projects with many branches.