Update database.pp: Remove output of plain-text passwords to screen and puppet console

[sleepingjack]

First of all - great module, very useful - thank you!

We are using puppet enterprise in an environment where passwords are not generally known by all team members. When running the puppet agent to install oracle, the database.pp causes the system passwords to be output in plain-text to the puppet console. In our environment this discloses information to people who do not need to know the passwords but do need to view server status and information on the puppet console.
The most important part of this update is the "show_diff" setting which prevents the console output.
For 'replace=>false': We have later on added code to copy /dev/null over the response file so that it is not left on the server holding the plain-text passwords. I'm not sure if this was the best fix but we needed something that didn't cause the file to be recreated on the next puppet run. Out change for this is outside the scope of oradb so I'm not sure the best file to change in oradb

Best Regards
Sarah

[biemond]

Thanks Sarah.

I will take a look at it, In chef template resource you got a sensitive attribute. there should be something in puppet to hide this.

cheers Edwin

[biemond]

what if we set loglevel on the file resource to warning or err . this should not display anything until there is something wrong.