Conversation
cl3m0
requested review from
cakemanny,
diefans,
jackiewmacharia,
rschach1 and
sofi-bm
Tiltfile
Outdated
| docker_build( | ||
| "licensing", | ||
| ".", | ||
| dockerfile_contents="FROM 676249682729.dkr.ecr.eu-central-1.amazonaws.com/licensing:{}".format( |
There was a problem hiding this comment.
I am wondering, if this an opensource project, how/if this is accessible... 🤔
There was a problem hiding this comment.
removed build_remote just before your review
k8s/Dockerfile.dev
Outdated
There was a problem hiding this comment.
What is the difference of Dockerfile and Dockerfile.dev? Tilt and GHA are using the latter... 🤔
There was a problem hiding this comment.
true... the only difference was the --log-config uvicorn_disable_logging.json parameter for uvivorn. renamed Dockerfile.devto Dockerfile and kept that one...
| firstname: str | ||
| lastname: str | ||
| phone: str | None | ||
| phone: Optional[str] = None |
There was a problem hiding this comment.
I had the impression that | is the new ergonomic way of defining Optional (without the need for this import)
See also: https://stackoverflow.com/questions/69440494/python-3-10-optionaltype-or-type-none
cl3m0
force-pushed
the
revive-project
branch
2 times, most recently
from
3b566f3 to
1b8be52
Compare
2 participants
This pull request includes several changes to the project configuration and build setup, focusing on improving the development workflow and updating dependencies. The most important changes include updates to the Docker and Kubernetes configurations, the introduction of Tilt for local development, and the addition of a GitHub Actions workflow for running tests.
Docker and Kubernetes Configuration Updates:
.dockerignore: Updated to ignore all files except for specific project-related files and directories.k8s/Dockerfileandk8s/Dockerfile.dev: Updated to useuvfor managing dependencies and virtual environments, and to build the project in multiple stages. [1] [2]Development Workflow Improvements:
.github/workflows/pytest.yml: Added a GitHub Actions workflow to run Python tests on pull requests, including setting up a PostgreSQL service.Tiltfile: Introduced a Tilt configuration for managing the Kubernetes resources and local development environment.Dependency and Configuration Updates:
.flake8: Added a configuration file for Flake8 to ignore specific rules and set maximum line length and complexity..python-version: Updated the Python version to 3.12.9.k8s/.nvmrc: Updated the Node.js version to v20.pyproject.tomlinstead of using requrements-files.Documentation Updates:
README.md: Updated to include instructions for using Tilt for local development and managing project dependencies withuv. [1] [2]Removal of Deprecated Kubernetes Configurations:
k8s/kustomization.yaml: Removed deprecated Kubernetes secret generation and resource configurations.