feat: April Fools fake math-themed ads#63
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
feat: April Fools fake math-themed ads#63devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
…pinning Tux Co-Authored-By: Oliver Ni <oliver.ni@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Oliver Ni <oliver.ni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds fake math-themed banner ads to the homepage for April Fools Day. Includes:
{% block sidebar_ads %}hook inbase.html(only overridden on the homepage)Ad lineup (each with a distinct visual style):
Updates since last revision
Review & Testing Checklist for Human
calc((100vw - 896px) / 2 - 180px)which hardcodes themax-w-4xl(896px) content width. Check that sidebars don't overlap content on viewports between 1280–1440px<hr>elements — ads 3–6 each add an<hr>above them. Before those ads load in (during the 2–4s delays), the page will show several consecutive horizontal rules with nothing between them. Decide if this is acceptablez-index: 9999, sidebar ads arez-index: 40, mobile menu isz-50. Verify Tux doesn't cover the mobile hamburger menuRecommended test plan: deploy to a preview environment, open the homepage on both a narrow (mobile) and wide (≥1440px) viewport, wait ~5s for all ads to load, scroll the full page, click a few ads and the Tux to confirm alerts fire.
Notes