Persistent term optimisations#148
Merged
josevalim merged 2 commits intobeam-telemetry:mainfrom Mar 10, 2026
Merged
Conversation
In `telemetry:attach_many/4`, we check if the function given to the config is an external function and log noisy errors if it is not, because the Erlang efficiency guide says these are more efficient. Enforce the same for the `telemetry_handler_table` module at least for the very hot path that looks up the handlers for an event. Also remove a case-of from the execution path for another picosecond shave off.
Contributor
Author
|
@josevalim :)) |
Contributor
|
cc @hauleth |
Contributor
|
LGTM |
josevalim
approved these changes
Mar 10, 2026
Contributor
|
💚 💙 💜 💛 ❤️ |
Contributor
Author
|
Great to see it merged 🎉 May we get a new hex release, 1.4.2 maybe? 🙃 |
Contributor
Author
@josevalim ☝🏽🙃 |
Contributor
|
I will do when I have some time available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the message for the first commit: