docs: fix incorrect paths and add missing demos to README#115
Open
skyc1e wants to merge 1 commit intobase:masterfrom
Open
docs: fix incorrect paths and add missing demos to README#115skyc1e wants to merge 1 commit intobase:masterfrom
skyc1e wants to merge 1 commit intobase:masterfrom
Conversation
The main README table had wrong paths for all MiniKit demos (referenced `minikit/` instead of actual `mini-apps/workshops/` and `mini-apps/templates/minikit/` directories). Also added 8 demos that were missing from the table entirely. Also fixed the clone path in new-mini-app-quickstart README which pointed to a non-existent `demos/minikit/waitlist-mini-app-qs` directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main README had several issues that would confuse newcomers trying to navigate the repo:
Incorrect paths (all MiniKit demos):
minikit/...but actual directories aremini-apps/workshops/...andmini-apps/templates/minikit/...minikit/mini-app-full-demo/which doesn't exist8 missing demos not listed in the table:
Wrong clone path in quickstart:
new-mini-app-quickstart/README.mdtold users tocd demos/minikit/waitlist-mini-app-qswhich doesn't existFiles changed
README.md— fixed all paths, added missing demosmini-apps/templates/minikit/new-mini-app-quickstart/README.md— fixed clone path