Skip to content

Fix function call ordering in dev deployment scripts#209

Merged
leopoldjoy merged 1 commit intomainfrom
fix/dev-deploy-script-ordering
Mar 20, 2026
Merged

Fix function call ordering in dev deployment scripts#209
leopoldjoy merged 1 commit intomainfrom
fix/dev-deploy-script-ordering

Conversation

@leopoldjoy
Copy link
Contributor

Both DeployDevNoNitro and DeployDevWithNitro had _registerProposer called before _deployInfrastructure and _deployTEEContracts, meaning it attempted to call setProposer on address(0) and would revert on every run.

Fix the ordering so infrastructure and TEE contracts are fully deployed before the proposer is registered:

1. _deployInfrastructure
2. _deployTEEContracts
3. _registerProposer
4. _deployAggregateVerifier

The bug was introduced in #201.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 20, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@leopoldjoy leopoldjoy merged commit 016a7e6 into main Mar 20, 2026
8 checks passed
@leopoldjoy leopoldjoy deleted the fix/dev-deploy-script-ordering branch March 20, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants