Conversation
AntonAndell
commented
Aug 8, 2024
Collaborator
Author
AntonAndell
left a comment
There was a problem hiding this comment.
Utils should be merged into the Current balanced utils
Flash loans should be able to be disabled as discussed
Protocol fees should be sent to the Balanced feeHandler.
Also if possible collect fees only from quote token on swaps
Collaborator
Author
|
A pool should inherit the Balanced rate limits and use on token transfers to limit runaways |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: