-
Notifications
You must be signed in to change notification settings - Fork 4
Add error topic deletion to clean up of consumer producer #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jkbe
wants to merge
4
commits into
master
Choose a base branch
from
fix/consumer-producer-clean-error-topic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e5d45f9
Add failing test for error topic clean up
jkbe 39af5fa
Add error topic deletion to clean up of consumer producer
jkbe 967153a
Introduce ErrorTopicCleanUpRunner to keep producer logic untouched
jkbe 5559b93
Introduce dedicated clean up runner for ConsumerProducer
jkbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
...rc/main/java/com/bakdata/kafka/consumerproducer/ConsumerProducerCleanUpConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 bakdata | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ | ||
|
|
||
| package com.bakdata.kafka.consumerproducer; | ||
|
|
||
| import com.bakdata.kafka.HasCleanHook; | ||
| import com.bakdata.kafka.HasTopicHooks; | ||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import lombok.NonNull; | ||
|
|
||
| /** | ||
| * Provides configuration options for {@link ConsumerProducerCleanUpRunner} | ||
| */ | ||
| public class ConsumerProducerCleanUpConfiguration implements HasTopicHooks<ConsumerProducerCleanUpConfiguration>, | ||
| HasCleanHook<ConsumerProducerCleanUpConfiguration>, AutoCloseable { | ||
| private final @NonNull Collection<TopicHook> topicHooks = new ArrayList<>(); | ||
| private final @NonNull Collection<Runnable> cleanHooks = new ArrayList<>(); | ||
| private final @NonNull Collection<Runnable> resetHooks = new ArrayList<>(); | ||
|
|
||
| /** | ||
| * Register a hook that is executed whenever a topic has been deleted by the cleanup runner. | ||
| */ | ||
| @Override | ||
| public ConsumerProducerCleanUpConfiguration registerTopicHook(final TopicHook hook) { | ||
| this.topicHooks.add(hook); | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Register a hook that is executed after {@link ConsumerProducerCleanUpRunner#clean()} has finished | ||
| */ | ||
| @Override | ||
| public ConsumerProducerCleanUpConfiguration registerCleanHook(final Runnable hook) { | ||
| this.cleanHooks.add(hook); | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Register a hook that is executed after {@link ConsumerProducerCleanUpRunner#reset()} has finished | ||
| * | ||
| * @param hook factory to create hook from | ||
| * @return self for chaining | ||
| */ | ||
| public ConsumerProducerCleanUpConfiguration registerResetHook(final Runnable hook) { | ||
| this.resetHooks.add(hook); | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| this.topicHooks.forEach(TopicHook::close); | ||
| } | ||
|
|
||
| void runTopicDeletionHooks(final String topic) { | ||
| this.topicHooks.forEach(hook -> hook.deleted(topic)); | ||
| } | ||
|
|
||
| void runCleanHooks() { | ||
| this.cleanHooks.forEach(Runnable::run); | ||
| } | ||
|
|
||
| void runResetHooks() { | ||
| this.resetHooks.forEach(Runnable::run); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #421 I moved this reset logic to ConsumerGroupClient which should make this code much more simple