feat: added support for granular template editor#13
Merged
ILLIA-KHOMENKO merged 9 commits intomainfrom Jan 28, 2026
Merged
Conversation
squirly
reviewed
Jan 22, 2026
squirly
reviewed
Jan 22, 2026
squirly
reviewed
Jan 22, 2026
squirly
reviewed
Jan 24, 2026
0xturner
reviewed
Jan 27, 2026
0xturner
approved these changes
Jan 27, 2026
squirly
reviewed
Feb 2, 2026
| sdk: BadgeSdk, | ||
| element: HTMLElement, | ||
| options: EmbedTemplatePageOptions, | ||
| {templateId, features, fonts, appearance}: EmbedTemplatePageOptions, |
Member
There was a problem hiding this comment.
Curious why destructuring was moved here? I think it is better to have it done outside the function call. This simplifies and adds clarity to the function signature when consuming.
Calling this options vs {templateId, features, fonts, appearance} when using.
squirly
reviewed
Feb 2, 2026
squirly
reviewed
Feb 2, 2026
squirly
pushed a commit
that referenced
this pull request
Feb 2, 2026
Closes: badge-dev/badge#3361 added embedTemplateEditorPage and support the granular editor features. <img width="1506" height="850" alt="image" src="https://github.com/user-attachments/assets/17107bd5-60bf-4c2e-817d-f2e195cc97da" />
ILLIA-KHOMENKO
added a commit
that referenced
this pull request
Feb 2, 2026
follow up improving type safety for PR: #13 Co-authored-by: Illia Khomenko <illia@trybadge.com>
squirly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added embedTemplateEditorPage and support the granular editor features.