feat(buffer-handler): add buffering support for external loggers#7994
Open
acascell wants to merge 3 commits intoaws-powertools:developfrom
Open
feat(buffer-handler): add buffering support for external loggers#7994acascell wants to merge 3 commits intoaws-powertools:developfrom
acascell wants to merge 3 commits intoaws-powertools:developfrom
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #7918
Summary
This PR implements log buffering support for external libraries when using AWS Lambda Powertools Logger with buffering enabled.
Changes
New
BufferingHandlerclass (aws_lambda_powertools/logging/buffer/handler.py):logging.Handler_add_log_record_to_buffer()functionEnhanced
copy_config_to_registered_loggers()function (aws_lambda_powertools/logging/utils.py):include_bufferingparameter (default:False)FalseUpdated configuration logic (
-):BufferingHandleroninclude_bufferingflagIncluded unit and functional tests
tests/functional/logger/required_dependencies/test_logger_utils.pytests/unit/logger/required_dependencies/test_logger_buffer_handler.pyUser Experience
Before this change:
When using Logger with buffering enabled, external library logs (botocore, mangum, etc.) were NOT buffered - they appeared immediately in CloudWatch, defeating the purpose of buffering:
Result: External library logs appeared immediately in CloudWatch, while application logs were buffered.
After this change:
External library logs are now buffered alongside application logs when
include_buffering=True:Result: All logs (application + external libraries) are buffered together and flushed as a unit
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.