Da poc upgrade 3.0 by MiguelDD1 · Pull Request #3 · availproject/substrate

MiguelDD1 · 2021-10-20T09:52:18Z

It upgrades da-poc branch to Substrate v3.0.0.

Upgrade to v3.0.0
Native tests have been re-enabled.
Wasm tests and force_change_to_new_set are disabled.

Files to review:

bin/node-template/node/src/chain_spec.rs
bin/node-template/node/src/service.rs
bin/node-template/runtime/src/lib.rs
frame/system/src/lib.rs
primitives/runtime/src/generic/header.rs

…#7866) * Add Prometheus alerts if unbounded channels are too large * Tweaks

Bumps [retain_mut](https://github.com/upsuper/retain_mut) from 0.1.1 to 0.1.2. - [Release notes](https://github.com/upsuper/retain_mut/releases) - [Commits](upsuper/retain_mut@v0.1.1...v0.1.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* babe: initialize next authorities on genesis * babe: add test for genesis authorities

* Add ss58 version prefix for CORD * Add ss58 version prefix for CORD

) * network-gossip: add metric for number of local messages * grandpa: fix GossipEngine missing metrics registry parameter * network-gossip: increase known messages cache size * network-gossip: fix tests * grandpa: remove unnecessary clone Co-authored-by: Max Inden <mail@max-inden.de> * network-gossip: count registered and expired messages separately * network-gossip: add comment on known messages cache size * network-gossip: extend comment with cache size in memory Co-authored-by: Max Inden <mail@max-inden.de>

* Remove statistics system * Remove ContextData struct * Remove next_request_id * Some TryFrom nit-picking * Use constants for peer sets

…tem (paritytech#7879) * Add `len` function that can return the length of a storage item efficiently * Make use of the new len function in contracts * Fix benchmarks * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Remove unused imports Co-authored-by: Parity Benchmarking Bot <admin@parity.io>

…#7848) * Fix clear prefix check to avoid erasing child trie roots. * Renaming and extend existing test with check. * last nitpicks.

…hore (paritytech#7887)

…thorities methods (paritytech#7892) * split authorities discovery keys for the current and next session * Revert "split authorities discovery keys for the current and next session" This reverts commit 0a40b8b. * pallet_authority_discovery: introduce a next_authorities method * address feedback * amend the doccomments

* make helper error types generics * avoid From<io::Error> dep in runner helper logic * slip of the pen, bump futures to 0.3.9 * more generics * generic var spaces Co-authored-by: Andronik Ordian <write@reusable.software> * network-gossip: add metric for number of local messages (paritytech#7871) * network-gossip: add metric for number of local messages * grandpa: fix GossipEngine missing metrics registry parameter * network-gossip: increase known messages cache size * network-gossip: fix tests * grandpa: remove unnecessary clone Co-authored-by: Max Inden <mail@max-inden.de> * network-gossip: count registered and expired messages separately * network-gossip: add comment on known messages cache size * network-gossip: extend comment with cache size in memory Co-authored-by: Max Inden <mail@max-inden.de> * Clean-up pass in network/src/protocol.rs (paritytech#7889) * Remove statistics system * Remove ContextData struct * Remove next_request_id * Some TryFrom nit-picking * Use constants for peer sets * contracts: Don't read the previous value when overwriting a storage item (paritytech#7879) * Add `len` function that can return the length of a storage item efficiently * Make use of the new len function in contracts * Fix benchmarks * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Remove unused imports Co-authored-by: Parity Benchmarking Bot <admin@parity.io> * Fix clear prefix check to avoid erasing child trie roots. (paritytech#7848) * Fix clear prefix check to avoid erasing child trie roots. * Renaming and extend existing test with check. * last nitpicks. * use follow paths to std standarad components * line width Co-authored-by: Bernhard Schuster <bernhard@parity.io> Co-authored-by: Andronik Ordian <write@reusable.software> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: Max Inden <mail@max-inden.de> Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> Co-authored-by: Alexander Theißen <alex.theissen@me.com> Co-authored-by: Parity Benchmarking Bot <admin@parity.io> Co-authored-by: cheme <emericchevalier.pro@gmail.com>

* Return FeeDetails in compute_fee_raw() * Add payment_queryDetails rpc * Simplify serde attribute a bit * Fix line width check * Use saturating_add() * Move transaction payment rpc types to types.rs * Add file header * Fix test * Update Cargo.lock * Nit * Apply the review suggestions * . * . * Fix serde * Fix rust doc * . * Update frame/transaction-payment/src/types.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Use NumberOrHex in fee details RPC * Address review feedback * Nits * Update some docs * Address review * Update frame/transaction-payment/src/types.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Happy 2021 * Nit * Address code review * Remove needless bound Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

…yed by a contract (paritytech#7870) * Add rent_payed field to the contract info * Don't pay out more as reward as was spent in rent * Make successful evictions free * Add tests to check that surcharge reward is capped by rent payed * review: Fixed docs

* Log target before prefix for more consistent logging As requested, this moves the target before the prefix to have consistent logging between logs with and without a prefix. * Add a space

* CI: trigger simnet master and wait for status * chore: remove leftovers from chaosnet; remove flaming-fir deployment

* CLI options and DB upgrade * Transaction storage * Block pruning * Block pruning test * Style * Naming * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Style Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* tests: fix UI test so we can update CI image * CI: remove diener installation from the script as it's installed in CI image * tests: another fix * tests: fix another fix * tests: NLoEOF * tests: another broken stderr

* *: Update to libp2p v0.34.0 * client/network: Update bytes, unsigned-varint and asynchronous-codec * client: Update to prost v0.7

* add concat Vec<u8> function and use it for better error logging in add_benchmark! macro * refactor benchmark error reporting to use format! and RuntimeString

* Adds a test for variable components * Clean up traces of common parameters which are removed now

…ytech#7785)

itzmeanjan

Only checked bin/node-template related files, looks good.

kroos47

Reviewed node-template, frame_system and runtime-primitives.
Didn't find any issues there, looks good.

Update to plonk 0.8.2

gui1117 and others added 30 commits January 12, 2021 09:25

bumpd minor version (paritytech#7873)

b2f10ed

Add Prometheus alerts if unbounded channels are too large (paritytech…

af88571

…#7866) * Add Prometheus alerts if unbounded channels are too large * Tweaks

babe: initialize next authorities on genesis (paritytech#7872)

7a52a74

* babe: initialize next authorities on genesis * babe: add test for genesis authorities

Update serde and parity-multiaddr, to fix master CI (paritytech#7877)

928b735

Add ss58 version prefix for CORD (from Dhiway) (paritytech#7862)

ecb85f7

* Add ss58 version prefix for CORD * Add ss58 version prefix for CORD

Clean-up pass in network/src/protocol.rs (paritytech#7889)

82d97c8

* Remove statistics system * Remove ContextData struct * Remove next_request_id * Some TryFrom nit-picking * Use constants for peer sets

Fix clear prefix check to avoid erasing child trie roots. (paritytech…

aa8b7db

…#7848) * Fix clear prefix check to avoid erasing child trie roots. * Renaming and extend existing test with check. * last nitpicks.

CI: test prometheus alerts moved to check; deploy depends on tests; c…

559e56b

…hore (paritytech#7887)

Use checked math when calculating storage size (paritytech#7885)

fae26bb

Update the Grafana dashboards (paritytech#7886)

a962daa

Log target before prefix for more consistent logging (paritytech#7897)

a9bbc7b

* Log target before prefix for more consistent logging As requested, this moves the target before the prefix to have consistent logging between logs with and without a prefix. * Add a space

contracts: Fix failing benchmark test (paritytech#7900)

d0b2e7d

CI: trigger simnet master and wait for status (paritytech#7899)

f1c6725

* CI: trigger simnet master and wait for status * chore: remove leftovers from chaosnet; remove flaming-fir deployment

tests: fix UI test so we can update CI image (paritytech#7901)

e6d498a

* tests: fix UI test so we can update CI image * CI: remove diener installation from the script as it's installed in CI image * tests: another fix * tests: fix another fix * tests: NLoEOF * tests: another broken stderr

*: Update to libp2p v0.34.0 (paritytech#7888)

bb3435a

* *: Update to libp2p v0.34.0 * client/network: Update bytes, unsigned-varint and asynchronous-codec * client: Update to prost v0.7

Fix bad debug_assert (paritytech#7904)

53fbef5

fix template (paritytech#7905)

bfd6826

improve benchmarking error output (paritytech#7863)

ab10fb5

* add concat Vec<u8> function and use it for better error logging in add_benchmark! macro * refactor benchmark error reporting to use format! and RuntimeString

Fix not restoring non-poisoned state (paritytech#7906)

caeb3b9

Add Test for Variable Components in Benchmarking (paritytech#7902)

23ece2f

* Adds a test for variable components * Clean up traces of common parameters which are removed now

fix cargo fmt (paritytech#7907)

946c0e1

Add ss58 version prefix for Patract/Jupiter (from PatractHubs) (parit…

cfb8157

…ytech#7785)

kroos47 and others added 6 commits October 13, 2021 18:28

fix:duration and chainSpec

a28790e

fix chainSpec

ea2aa46

fix:chainSpec

fe317f3

changed spec name

7b082c7

Migration to V3.0.0

f089224

Upgrade to V3.0.0

98938e0

MiguelDD1 self-assigned this Oct 25, 2021

MiguelDD1 added 8 commits October 25, 2021 17:51

Fix issuees from formatter

77d0a5e

Fix UT related with KC params

719bf43

Fix UT about Genesis and KC Params

9c79723

Fix UT signed_ext_check_weight_block_size_works

31768db

UT fixes: Genesis requires Kate Pub Params

030d506

Fix Genesis on tests

d0fd481

Im-online enabled & update

10dab41

Fix Genesis of ImOnline

0f45442

MiguelDD1 changed the title ~~[WIP] Da poc upgrade 3.0~~ Da poc upgrade 3.0 Nov 7, 2021

MiguelDD1 marked this pull request as ready for review November 7, 2021 23:10

Merge branch 'da-poc' into da-poc-upgrade-3.0

cd21485

prabal-banerjee requested review from itzmeanjan, kroos47 and prabal-banerjee November 9, 2021 07:27

MiguelDD1 and others added 3 commits November 14, 2021 20:12

Remove internal plonk & fix deps

ebfdd1b

Enable benchmarking on node-template

4d87f6b

Enable benchmarking on node-template

7fcc491

itzmeanjan approved these changes Nov 19, 2021

View reviewed changes

kroos47 reviewed Nov 19, 2021

View reviewed changes

MiguelDD1 and others added 4 commits November 21, 2021 22:11

Fix impl-serde dependency

f65b162

Re-enable some UTs

db49c7e

Fix benchmarking & plonk dep to tag

4484f6c

Merge pull request #6 from maticnetwork/feature/MAT-3320/update_plonk

0c92099

Update to plonk 0.8.2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Da poc upgrade 3.0#3

Da poc upgrade 3.0#3
MiguelDD1 wants to merge 232 commits intoda-pocfrom
da-poc-upgrade-3.0

MiguelDD1 commented Oct 20, 2021 •

edited

Loading

Uh oh!

itzmeanjan left a comment

Uh oh!

kroos47 left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

MiguelDD1 commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itzmeanjan left a comment

Choose a reason for hiding this comment

Uh oh!

kroos47 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

MiguelDD1 commented Oct 20, 2021 •

edited

Loading

kroos47 left a comment •

edited

Loading