feat: allow underscore prefix for private identifiers#156
Open
ivanauth wants to merge 1 commit intoauthzed:mainfrom
Open
feat: allow underscore prefix for private identifiers#156ivanauth wants to merge 1 commit intoauthzed:mainfrom
ivanauth wants to merge 1 commit intoauthzed:mainfrom
Conversation
…n identifiers
Updates regex patterns across all API protos to allow identifiers to
begin with an underscore (`_`). This enables a convention for marking
identifiers as "private" or "internal".
Use cases:
- **Synthetic permissions**: Permissions that exist only to compose other permissions
- **Internal relations**: Relations not meant to be directly referenced by application code
- **Implementation details**: Parts of your schema that may change without affecting the public API
Example:
```zed
definition document {
relation viewer: user
relation _internal_viewer: user
// Private synthetic permission
permission _can_view = viewer + _internal_viewer
// Public permission
permission view = _can_view
}
```
Companion PR to authzed/spicedb#2733
ivanauth
force-pushed
the
feat/underscore-prefix-identifiers
branch
from
902798a to
4b26b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_) for definition, relation, and permission identifiersDescription
This PR updates the validation regex patterns to allow identifiers to begin with an underscore. This establishes a convention for marking identifiers as "private" or "internal".
Use cases:
Example Usage
Changes
core.prototo allow underscore-prefixed identifierspermission_service.protoexperimental_service.protowatch_service.protoRelated