Skip to content

Fix Firefox folder drag-and-drop targeting#254

Merged
jorgebaralt merged 4 commits intomainfrom
jorge/feat/drag-updates
Mar 19, 2026
Merged

Fix Firefox folder drag-and-drop targeting#254
jorgebaralt merged 4 commits intomainfrom
jorge/feat/drag-updates

Conversation

@jorgebaralt
Copy link
Copy Markdown
Contributor

@jorgebaralt jorgebaralt commented Mar 19, 2026

Summary

  • add a shared tree DnD collision helper that prioritizes inside/parent targets and falls back from pointerWithin to rectIntersection
  • apply the shared hit zones and drag overlay to both the sidebar tree and the folder nested-pages tree
  • add regression tests for collision prioritization, fallback behavior, empty parent targets, and reorder-only cases

Testing

  • pnpm --filter @acme/web exec vitest run tests/env.test.ts tests/tree-dnd.test.ts
  • pnpm --filter @acme/web typecheck

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 19, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
journl Ready Ready Preview, Comment Mar 19, 2026 3:48am

@jorgebaralt @claude
Extract shared sidebar tree row classnames into constants
c57d56e 
Add app-sidebar-tree-row.ts with shared classname constants and update
sidebar components to use them. Remove redundant tree-dnd.ts re-export.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jorgebaralt jorgebaralt merged commit 0549382 into main Mar 19, 2026
5 checks passed
@jorgebaralt jorgebaralt deleted the jorge/feat/drag-updates branch March 19, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jorgebaralt