This repository was archived by the owner on Dec 16, 2023. It is now read-only.
Adds location.port and location.searchParams#1193
Open
unblu-kschiess wants to merge 4 commits intoassaf:masterfrom
unblu-kschiess:feature/document.location-enhancements
Open
Adds location.port and location.searchParams#1193unblu-kschiess wants to merge 4 commits intoassaf:masterfrom unblu-kschiess:feature/document.location-enhancements
unblu-kschiess wants to merge 4 commits intoassaf:masterfrom
unblu-kschiess:feature/document.location-enhancements
Conversation
and replace it with whatwg-url implementation. This reduces the number of url implementations to 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally this PR removes the old DOMURL implementation; the code now uses NodeJS' standard 'url' library and 'whatwg-url'. The old DOMURL was very similar to whatwg-url; tests pass, so I am assuming that this can go.