Add service connection for NugetAuthenticate#778
Merged
phil-allen-msft merged 1 commit intomainfrom Jan 10, 2025
Merged
Conversation
Contributor
|
how does this remove the need for #776? That addresses the scenario where anyone who doesn't have permissions to push packages to the azure-public feed cannot build libman when either:
|
jimmylewis
approved these changes
Jan 10, 2025
Contributor
jimmylewis
left a comment
jimmylewis
left a comment
There was a problem hiding this comment.
LGTM except for my other comment about the PR description.
Contributor
Author
|
I looked at the code change; the code change would seem to give an alternative source for packages, which the service connection fix (here) is at least related for. But on closer look, it is indeed a separate scenario. Modifying the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add service connection conditionally
Update "Install .NET SDK" action to use the contents of global.json to determine the version of the SDK to install