Load extension parameters via simple ContextInitializer instead of EnvironmentLoader.#20
Open
kolotaev wants to merge 2 commits intoasgorobets:masterfrom
Open
Load extension parameters via simple ContextInitializer instead of EnvironmentLoader.#20kolotaev wants to merge 2 commits intoasgorobets:masterfrom
kolotaev wants to merge 2 commits intoasgorobets:masterfrom
Conversation
…vironmentLoader. It allows us to extend SoapContext in custom FeatureContexts. Otherwise EnvironmentLoader always add SoapContext steps on every test thus causing potential steps duplication in SoapContext and its descendant classes.
|
@kolotaev, if you want to remove the environment loader then the PR must have tests and usage examples added to the documentation since autoloading of contexts will no longer happen. |
Author
|
@BR0kEN-, thanks! I've added a behat test and a use-case example that uses extended SOAPContext. If you apply commit that adds tests to the current upstream's master branch you'll see the following error: |
Author
|
@BR0kEN-, sorry for pinging you once again, but is it possible to review and merge this PR and add it to a new release? Our production code tests depend on it. Otherwise, I'd appreciate if you point out what should be adjusted in the PR so that I can amend it. Thank you in advance! |
|
We need @asgorobets here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to extend SoapContext in custom any FeatureContext.
It allows us to extend SoapContext in custom FeatureContexts. Otherwise EnvironmentLoader always add SoapContext steps on every test thus causing potential steps duplication in SoapContext and its descendant classes.