Skip to content

Load extension parameters via simple ContextInitializer instead of EnvironmentLoader.#20

Open
kolotaev wants to merge 2 commits intoasgorobets:masterfrom
kolotaev:IDM-297
Open

Load extension parameters via simple ContextInitializer instead of EnvironmentLoader.#20
kolotaev wants to merge 2 commits intoasgorobets:masterfrom
kolotaev:IDM-297

Conversation

@kolotaev
Copy link
Copy Markdown

Currently it's not possible to extend SoapContext in custom any FeatureContext.

It allows us to extend SoapContext in custom FeatureContexts. Otherwise EnvironmentLoader always add SoapContext steps on every test thus causing potential steps duplication in SoapContext and its descendant classes.

…vironmentLoader.

It allows us to extend SoapContext in custom FeatureContexts. Otherwise EnvironmentLoader always add SoapContext steps on every test thus causing potential steps duplication in SoapContext and its descendant classes.
@BR0kEN-
Copy link
Copy Markdown

BR0kEN- commented Feb 15, 2018

@kolotaev, if you want to remove the environment loader then the PR must have tests and usage examples added to the documentation since autoloading of contexts will no longer happen.

@kolotaev
Copy link
Copy Markdown
Author

@BR0kEN-, thanks! I've added a behat test and a use-case example that uses extended SOAPContext.

If you apply commit that adds tests to the current upstream's master branch you'll see the following error:

Step "I am working with SOAP service WSDL :wsdl" is already defined in Behat\SoapExtension\Context\Bootstrap\ExtendedSoapContext::iAmWorkingWithSoapServiceWSDL()
Behat\SoapExtension\Context\Bootstrap\ExtendedSoapContext::iAmWorkingWithSoapServiceWSDL()
Behat\SoapExtension\Context\SoapContext::iAmWorkingWithSoapServiceWSDL()

@kolotaev
Copy link
Copy Markdown
Author

kolotaev commented Mar 2, 2018

@BR0kEN-, sorry for pinging you once again, but is it possible to review and merge this PR and add it to a new release? Our production code tests depend on it. Otherwise, I'd appreciate if you point out what should be adjusted in the PR so that I can amend it. Thank you in advance!

@BR0kEN-
Copy link
Copy Markdown

BR0kEN- commented Mar 2, 2018

We need @asgorobets here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants