š fix(storage): improve S3-compatible provider support and error handā¦#64
Merged
656d696c65 merged 1 commit intomainfrom Mar 12, 2026
Merged
š fix(storage): improve S3-compatible provider support and error handā¦#64656d696c65 merged 1 commit intomainfrom
656d696c65 merged 1 commit intomainfrom
Conversation
ā¦ling - move "Unknown error" log into else branch in server.ts to avoid duplicate logging after known errors - remove ACL: "private" from PutObjectCommand in generatePutSignedUrl and putObject as some S3-compatible providers do not support ACLs - remove httpStatusCode 403 from bucket-not-found conditions in ensureStorageBucket - log warning instead of throwing on non-standard HeadBucket error codes to prevent server crash with providers like OpenStack Swift - log confirmation message when bucket is accessible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ā¦ling