fix(AWSCreds): Caused by race condition while processing s3 artifact#304
Open
tonyg4864 wants to merge 1 commit intoarmory:masterfrom
Open
fix(AWSCreds): Caused by race condition while processing s3 artifact#304tonyg4864 wants to merge 1 commit intoarmory:masterfrom
tonyg4864 wants to merge 1 commit intoarmory:masterfrom
Conversation
tonyg4864
commented
Sep 19, 2025
tonyg4864
commented
- Fixed issue where AWS secret env variable was missing from clouddriver components when running in HA mode. Specifically when enabling s3 artifact credentials.
jasonmcintosh
approved these changes
Jan 5, 2026
jasonmcintosh
left a comment
jasonmcintosh
left a comment
There was a problem hiding this comment.
I'll note: This is pretty much "deprecated" at this point in favor of kustomize, but this still looks like a nice fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.