Open
Conversation
After having discussions internally, the logic for working with the Trivy Cloud integration is going to be simplified greatly. This involves removing the Cloud specific config file and bringing the config into the existing Trivy config. The `cloud config` commands will be removed as they aren't needed anymore. As the focus is going to be on CI/CD integration with the Trivy Cloud platform, there isn't currently a need to have the Login and Logout mechanisms.
Add login/logout flow to get a token from the API using the browser. Login with trivy login, if providing --token, that will be stored in the keyring, if not, the browser will be opened up to login and generate a token and callback to the cli before saving to the keyring. Some small updates to the log prefix Generate the docs for the new commands
owenrumney
force-pushed
the
feat/login-with-browser
branch
from
b066a56 to
5d0aaff
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 27 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After having discussions internally, the logic for working with the Trivy Cloud integration is going to be simplified greatly. This involves removing the Cloud specific config file and bringing the config into the existing Trivy config. The
cloud configcommands will be removed as they aren't needed anymore.TRIVY_PRO_TOKENenv var can be used to loginKapture.2025-11-26.at.12.40.34.mp4
Related issues
Closes #9693
Closes #9746
Checklist