chore(deps): update konflux references#659
chore(deps): update konflux references#659red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a app-sre member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughUpdated multiple Tekton PipelineRun YAMLs: refreshed pinned task bundle digests (sha256), bumped Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.tekton/deployment-validation-operator-pull-request.yaml (1)
248-266:⚠️ Potential issue | 🟡 MinorVerify handling of the
build-image-index=falsebehavior change in v0.3.Upgrading
task-build-image-indexto v0.3 changes howALWAYS_BUILD_INDEX=falsebehaves with multiple images: v0.2 would fail when given multiple images withALWAYS_BUILD_INDEX=false, but v0.3 now creates an index anyway. Since this pipeline passes multiple platform images by default (linux/x86_64andlinux/arm64) and exposesbuild-image-indexas a public parameter, callers setting it tofalsewill experience a silent behavior change. Confirm whether any callers rely on the old semantics, and consider documenting this change.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.tekton/deployment-validation-operator-pull-request.yaml around lines 248 - 266, The pipeline now uses the task "build-image-index" with the param ALWAYS_BUILD_INDEX (and public pipeline param build-image-index), but version 0.3 of task-build-image-index changes semantics so ALWAYS_BUILD_INDEX=false no longer prevents index creation when multiple images are passed; update this PR by auditing callers of the pipeline parameter build-image-index to see who relies on the old behavior, and either (a) pin the taskRef to the older task-build-image-index version if backward compatibility is required, or (b) add explicit documentation and a note in the pipeline parameter description (for build-image-index / ALWAYS_BUILD_INDEX) explaining the v0.3 behavior change and its impact when IMAGES contains multiple platform images, and optionally add logic (e.g., a guard task or conditional) to mimic the old failing behavior if you must preserve prior semantics.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.tekton/deployment-validation-operator-pull-request.yaml:
- Around line 248-266: The pipeline now uses the task "build-image-index" with
the param ALWAYS_BUILD_INDEX (and public pipeline param build-image-index), but
version 0.3 of task-build-image-index changes semantics so
ALWAYS_BUILD_INDEX=false no longer prevents index creation when multiple images
are passed; update this PR by auditing callers of the pipeline parameter
build-image-index to see who relies on the old behavior, and either (a) pin the
taskRef to the older task-build-image-index version if backward compatibility is
required, or (b) add explicit documentation and a note in the pipeline parameter
description (for build-image-index / ALWAYS_BUILD_INDEX) explaining the v0.3
behavior change and its impact when IMAGES contains multiple platform images,
and optionally add logic (e.g., a guard task or conditional) to mimic the old
failing behavior if you must preserve prior semantics.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 14ce1295-b1e6-41fc-be8b-24e9adda9a6a
📒 Files selected for processing (20)
.tekton/deployment-validation-operator-bundle-pull-request.yaml.tekton/deployment-validation-operator-bundle-push.yaml.tekton/deployment-validation-operator-pull-request.yaml.tekton/deployment-validation-operator-push.yaml.tekton/fbc-ocp4-12-pull-request.yaml.tekton/fbc-ocp4-12-push.yaml.tekton/fbc-ocp4-13-pull-request.yaml.tekton/fbc-ocp4-13-push.yaml.tekton/fbc-ocp4-14-pull-request.yaml.tekton/fbc-ocp4-14-push.yaml.tekton/fbc-ocp4-15-pull-request.yaml.tekton/fbc-ocp4-15-push.yaml.tekton/fbc-ocp4-16-pull-request.yaml.tekton/fbc-ocp4-16-push.yaml.tekton/fbc-ocp4-17-pull-request.yaml.tekton/fbc-ocp4-17-push.yaml.tekton/fbc-ocp4-18-pull-request.yaml.tekton/fbc-ocp4-18-push.yaml.tekton/fbc-ocp4-19-pull-request.yaml.tekton/fbc-ocp4-19-push.yaml
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncaak, red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
red-hat-konflux
bot
force-pushed
the
konflux/references/master
branch
from
272e2e0 to
3639778
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
=======================================
Coverage 46.16% 46.16%
=======================================
Files 22 22
Lines 1083 1083
=======================================
Hits 500 500
Misses 553 553
Partials 30 30 🚀 New features to boost your workflow:
|
|
/lgtm |
|
/test deployment-validation-operator-e2e-tests |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
bot
force-pushed
the
konflux/references/master
branch
from
3639778 to
add0b4d
Compare
|
New changes are detected. LGTM label has been removed. |
|
@red-hat-konflux[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This PR contains the following updates:
0.2→0.3cad04a0→1da40a1351b8f1→4b3b7683fa03be→8992475de35caf→8b501440312f05→54bcb482229dbc→9917d110eb4cfb→7f2e8ed47f4e2d→e92d00ec89a2bc→c4ef47eba3eff8→2ad986f92552dd→0854d92Release Notes
konflux-ci/build-definitions (quay.io/konflux-ci/tekton-catalog/task-build-image-index)
v0.3Changed
konflux-build-clifor the build step instead of an inline bashimplementation. This provides more robust error handling and simplified maintenance.
ALWAYS_BUILD_INDEXisfalseand multiple images are provided, the task nowcreates an image index instead of failing. The previous behavior (failing with an error)
was not useful.
Removed
COMMIT_SHAparameter (was not used by the task implementation)IMAGE_EXPIRES_AFTERparameter (was not used by the task implementation)Added
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.