Feat: add bullet shortcut for Mac users#59
Open
conmcdon721 wants to merge 1 commit intoapankrat:masterfrom
Open
Feat: add bullet shortcut for Mac users#59conmcdon721 wants to merge 1 commit intoapankrat:masterfrom
conmcdon721 wants to merge 1 commit intoapankrat:masterfrom
Conversation
I'm using nullboard on a Mac and couldn't figure out how to add bullet points. On line 4709 of nullboard.html, I found the shortcut for adding bullet points on Windows. I added an OR to the conditional so it includes the Mac's Command key. In my OR conditional, I included both the Shift key and the 8 key. For some reason, the asterisk key wasn't working for me. Moreover, I used the Meta key instead of the Command key's key-code. I did this to minimize the necessary code: the left and the right Command keys have different key-codes, and the Command keys' key-codes are different for each browser. The drawback to this addition is that Windows users may unintentionally create the event by pressing the Windows key, which is also a Meta key.
Owner
|
Hi Connor, Can you run a quick test for me? Add
This is not an issue. Chances of anyone ever using |
|
I had this same issue, the or statement worked perfect for the MacOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using nullboard on a Mac and couldn't figure out how to add bullet
points. On line 4709 of nullboard.html, I found the shortcut for adding
bullet points on Windows. I added an OR to the conditional so it
includes the Mac's Command key.
In my OR conditional, I included both the Shift key and the 8 key. For
some reason, the asterisk key wasn't working for me. Moreover, I used
the Meta key instead of the Command key's key-code. I did this to
minimize the necessary code: the left and the right Command keys have
different key-codes, and the Command keys' key-codes are different for
each browser.
The drawback to this addition is that Windows users may unintentionally
create the event by pressing the Windows key, which is also a Meta key.