Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #739 +/- ##
===========================================
- Coverage 62.09% 61.78% -0.32%
===========================================
Files 700 701 +1
Lines 40142 40719 +577
Branches 5650 5784 +134
===========================================
+ Hits 24926 25157 +231
- Misses 14522 14821 +299
- Partials 694 741 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
Mar 16, 2026
Comment on lines
+325
to
+352
| uint8_t* null_bitmap = nullptr; | ||
| if (has_null) { | ||
| size_t null_bitmap_size = GetNullBitmapSize(row_count); | ||
| null_bitmap = static_cast<uint8_t*>( | ||
| common::mem_alloc(null_bitmap_size, common::MOD_TSBLOCK)); | ||
| if (null_bitmap == nullptr) { | ||
| common::mem_free(array_data->buffers); | ||
| common::mem_free(array_data); | ||
| return common::E_OOM; | ||
| } | ||
| common::BitMap& vec_bitmap = vec->get_bitmap(); | ||
| char* vec_bitmap_data = vec_bitmap.get_bitmap(); | ||
| for (size_t i = 0; i < null_bitmap_size; ++i) { | ||
| null_bitmap[i] = ~static_cast<uint8_t>(vec_bitmap_data[i]); | ||
| } | ||
| array_data->buffers[0] = null_bitmap; | ||
|
|
||
| int64_t null_count = 0; | ||
| for (uint32_t i = 0; i < row_count; ++i) { | ||
| if (vec_bitmap.test(i)) { | ||
| null_count++; | ||
| } | ||
| } | ||
| out_array->null_count = null_count; | ||
| } else { | ||
| array_data->buffers[0] = nullptr; | ||
| out_array->null_count = 0; | ||
| } |
Contributor
There was a problem hiding this comment.
The same as BuildFixedLengthArrowArrayC? May extract.
| char* vec_data = vec->get_value_data().get_data(); | ||
| uint32_t vec_offset = 0; | ||
|
|
||
| // 获取 vec_bitmap 用于后续检查 |
Comment on lines
+377
to
+379
| uint32_t len = 0; | ||
| std::memcpy(&len, vec_data + vec_offset, sizeof(uint32_t)); | ||
| vec_offset += sizeof(uint32_t); |
Contributor
There was a problem hiding this comment.
len = ((uint32_t) (vec_data + vec_offset)) ?
Contributor
There was a problem hiding this comment.
You may copy length and content in one pass, because the total content length can be calculated by len(vec_data) - row_count*sizeof(uint32_t).
Comment on lines
+434
to
+457
| // Convert TsFile YYYYMMDD integer to days since Unix epoch (1970-01-01) | ||
| static int32_t YYYYMMDDToDaysSinceEpoch(int32_t yyyymmdd) { | ||
| int year = yyyymmdd / 10000; | ||
| int month = (yyyymmdd % 10000) / 100; | ||
| int day = yyyymmdd % 100; | ||
|
|
||
| std::tm date = {}; | ||
| date.tm_year = year - 1900; | ||
| date.tm_mon = month - 1; | ||
| date.tm_mday = day; | ||
| date.tm_hour = 12; | ||
| date.tm_isdst = -1; | ||
|
|
||
| std::tm epoch = {}; | ||
| epoch.tm_year = 70; | ||
| epoch.tm_mon = 0; | ||
| epoch.tm_mday = 1; | ||
| epoch.tm_hour = 12; | ||
| epoch.tm_isdst = -1; | ||
|
|
||
| time_t t1 = mktime(&date); | ||
| time_t t2 = mktime(&epoch); | ||
| return static_cast<int32_t>((t1 - t2) / (60 * 60 * 24)); | ||
| } |
Comment on lines
+481
to
+505
| common::BitMap& vec_bitmap = vec->get_bitmap(); | ||
| uint8_t* null_bitmap = nullptr; | ||
| if (has_null) { | ||
| size_t null_bitmap_size = GetNullBitmapSize(row_count); | ||
| null_bitmap = static_cast<uint8_t*>( | ||
| common::mem_alloc(null_bitmap_size, common::MOD_TSBLOCK)); | ||
| if (null_bitmap == nullptr) { | ||
| common::mem_free(array_data->buffers); | ||
| common::mem_free(array_data); | ||
| return common::E_OOM; | ||
| } | ||
| char* vec_bitmap_data = vec_bitmap.get_bitmap(); | ||
| for (size_t i = 0; i < null_bitmap_size; ++i) { | ||
| null_bitmap[i] = ~static_cast<uint8_t>(vec_bitmap_data[i]); | ||
| } | ||
| int64_t null_count = 0; | ||
| for (uint32_t i = 0; i < row_count; ++i) { | ||
| if (vec_bitmap.test(i)) null_count++; | ||
| } | ||
| out_array->null_count = null_count; | ||
| array_data->buffers[0] = null_bitmap; | ||
| } else { | ||
| out_array->null_count = 0; | ||
| array_data->buffers[0] = nullptr; | ||
| } |
Comment on lines
+54
to
+60
| if (batch_size == 0) { | ||
| block_size_ = 1024; | ||
| batch_mode_ = false; | ||
| } else { | ||
| block_size_ = batch_size; | ||
| batch_mode_ = true; | ||
| } |
Contributor
There was a problem hiding this comment.
batch_size == 0 -> batch_size <= 0, or use uint
Comment on lines
+421
to
+426
| // // Test 2: Batch query (batch_size = 1000) | ||
| // { | ||
| // storage::TsFileReader reader; | ||
| // int ret = reader.open(file_name_); | ||
| // ASSERT_EQ(ret, common::E_OK); | ||
| // |
Comment on lines
+162
to
+166
| if code != 0: | ||
| return None | ||
|
|
||
| if arrow_schema.release == NULL or arrow_array.release == NULL: | ||
| return None |
| pandas==2.2.2 | ||
| setuptools==78.1.1 | ||
| wheel==0.46.2 | ||
| pyarrow |
Contributor
There was a problem hiding this comment.
Better to specify a minimum version?
|
|
||
| tsfile_include_dir = os.path.join(project_dir, "tsfile", "include") | ||
|
|
||
| extra_compile_args = ["-O0", "-g3", "-fno-omit-frame-pointer"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.