fix: add quotes around enum string values in visualization operators#4351
Open
xuang7 wants to merge 1 commit intoapache:mainfrom
Open
fix: add quotes around enum string values in visualization operators#4351xuang7 wants to merge 1 commit intoapache:mainfrom
xuang7 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
Can we add test cases to catch this problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds quotes around plain String values returned by Java enum methods in three visualization operators so the generated Python code is valid:
Any related issues, documentation, discussions?
Related to #4189
Resolves #4350
How was this PR tested?
Existing tests passed
Was this PR authored or co-authored using generative AI tooling?
No