Skip to content

[SPARK-56048][UI] Add copy plan text and share link buttons to SQL execution page#54886

Closed
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-56048
Closed

[SPARK-56048][UI] Add copy plan text and share link buttons to SQL execution page#54886
yaooqinn wants to merge 1 commit intoapache:masterfrom
yaooqinn:SPARK-56048

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Mar 18, 2026

What changes were proposed in this pull request?

Add two buttons next to the existing Download button on the SQL execution detail page:

  • 📋 Copy Plan — copies the physical plan text to clipboard
  • 🔗 Copy Link — copies the current page URL to clipboard

Both use navigator.clipboard.writeText and show a toast notification on success.

Why are the changes needed?

When debugging query performance, users frequently need to share the physical plan or page link via Slack/JIRA/email. Currently they must manually select text or copy the URL bar. One-click buttons improve this workflow.

Does this PR introduce any user-facing change?

Yes — two new buttons on the SQL execution detail page.

How was this patch tested?

Compilation verified. Manual testing.

Was this patch authored or co-authored using generative AI tooling?

Yes, Generated-by: GitHub Copilot(claude-opus-4.6-1m).

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @yaooqinn .

@dongjoon-hyun
Copy link
Member

ditto


BTW, are you going to use your personal message instead of complying the Apache Spark Pull Request template, @yaooqinn ?

Screenshot 2026-03-18 at 11 48 41

I'm not sure why the Copilot ignores the pull request template, but when I ask Cluade Caude to write a PR description based on the pull request template (here, I used the file reference feature of Claude Claude), Claude Code works well by respecting the Apache Spark Pull Request template like the following. In these days, it's rare to write the PR description from the scratches. I assume that you are also taking advantage of Copilot for your PR description writing.

Screenshot 2026-03-18 at 11 51 08

If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.

…ecution page

Add two buttons next to the existing Download button on the SQL
execution detail page:
- 'Copy Plan' — copies the physical plan text to clipboard
- 'Copy Link' — copies the current page URL to clipboard

Both use navigator.clipboard.writeText and show a toast notification
on success (via the existing showToast helper from SPARK-55769).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@yaooqinn
Copy link
Member Author

Merged to master, thank you @dongjoon-hyun

@yaooqinn yaooqinn deleted the SPARK-56048 branch March 19, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants