[SPARK-36600][SQL] Avoid unnecessary list conversion in createDataFrame#54882
Open
adityaksolves wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-36600][SQL] Avoid unnecessary list conversion in createDataFrame#54882adityaksolves wants to merge 1 commit intoapache:masterfrom
adityaksolves wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
cc @HyukjinKwon - I have fixed the memory issue and all tests are passing (Build #4). This is ready for review and should be linked to [SPARK-36600]. Can the Spark QA bot please trigger the JIRA link? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors _createFromLocal in python/pyspark/sql/session.py to support lazy evaluation of generators when a StructType schema is provided. Previously, the code forced a list(data) conversion, which caused OutOfMemoryError for large datasets.
Key changes:
Why are the changes needed?
Currently, createDataFrame consumes the entire input collection into a local Python list before parallelizing it. When users pass a generator containing millions of rows (even with a predefined schema), the driver node exhausts its memory. This change allows Spark to stream the generator data directly into the RDD creation process.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The patch was tested using the existing PySpark unit test suite.
Was this patch authored or co-authored using generative AI tooling?
No