[SPARK-55448][CONNECT] Fix query events loss when session closes during query execution#54225
Open
biruktesf-db wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-55448][CONNECT] Fix query events loss when session closes during query execution#54225biruktesf-db wants to merge 1 commit intoapache:masterfrom
biruktesf-db wants to merge 1 commit intoapache:masterfrom
Conversation
hvanhovell
approved these changes
Feb 26, 2026
Contributor
|
@biruktesf-db can you update the PR? |
Contributor
|
LGTM (with a small adjustment of the exception message). |
terana
approved these changes
Feb 27, 2026
| sessionHolder.eventManager.status != SessionStatus.Closed) { | ||
| throw new IllegalStateException(s""" | ||
| sessionId: $sessionId with status $sessionStatus | ||
| is not Started for event $eventStatus |
Contributor
There was a problem hiding this comment.
nit: also need to update the comment?
81d0d31 to
796d8f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow Spark Connect to send query events after the session is closed.
Why are the changes needed?
A race condition exists between Spark Connect session closure and execution cleanup. When a session closes while an execution is still running:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added unit tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code v2.1.37