Skip to content

[#2578] Filter extra cookies on resubmit#2588

Draft
lprimak wants to merge 2 commits intoapache:mainfrom
lprimak:filter-extra-cookies-on-resubmit
Draft

[#2578] Filter extra cookies on resubmit#2588
lprimak wants to merge 2 commits intoapache:mainfrom
lprimak:filter-extra-cookies-on-resubmit

Conversation

@lprimak
Copy link
Contributor

@lprimak lprimak commented Feb 28, 2026

When resubmitting in conjunction with rememberMe and distributed sessions that use JSESSIONIDVERSION cookie, both of them trample with resubmit logic and need to be filtered out

fixes #2578

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@github-actions github-actions bot added the java Pull requests that update Java code label Feb 28, 2026
@lprimak lprimak changed the title Filter extra cookies on resubmit [#2578] Filter extra cookies on resubmit Feb 28, 2026
@lprimak lprimak added this to the 3.0.0 milestone Feb 28, 2026
@lprimak lprimak force-pushed the filter-extra-cookies-on-resubmit branch from 8a8178d to 7343f29 Compare February 28, 2026 04:57
@lprimak lprimak marked this pull request as draft February 28, 2026 06:39
…on ID cookies themselves.

This prevents spurious session ID version cookies from getting in
@lprimak lprimak force-pushed the filter-extra-cookies-on-resubmit branch from c4b552e to fbd38c4 Compare February 28, 2026 17:14
@lprimak lprimak changed the base branch from 3.x to main February 28, 2026 17:14
@lprimak lprimak closed this Feb 28, 2026
@lprimak lprimak reopened this Feb 28, 2026
@lprimak lprimak modified the milestones: 3.0.0, 2.1.1 Feb 28, 2026
@lprimak lprimak marked this pull request as ready for review February 28, 2026 18:23
@lprimak lprimak marked this pull request as draft March 1, 2026 03:02
@lprimak
Copy link
Contributor Author

lprimak commented Mar 1, 2026

Ugh. Failing sporadically still but in a different way (302 redirect instead of an exception)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] EE resubmit with JSESSIONIDVERSION cookie

1 participant