Bump toml-java to 13.5.1 for TOMLv1.1#9242
Conversation
|
D'oh, looks like I should be adding some label or something, as the old version is still being used (caching?) |
you have to update the edit:
all good its there: https://repo1.maven.org/maven2/net/vieiro/toml-java/13.5.1/ |
Ah, very true! Thanks, @mbien ! |
|
@vieiro thanks for the update. I integrated the released version into my experimental rust-analyser branch (bumping from my personal toml-java build). The update branch can be found here: The branch can be found here: https://github.com/matthiasblaesing/netbeans/tree/rust-analyser The commit integrating the updated toml-java is here: 3a8d890 In addition to updating the binary it also bumps the major version of the module as the API was broken (see required sigfile update). To expand the info from @mbien: The |
Thanks @matthiasblaesing . |
|
D'oh!, forgot to update the version of the module. Will do that. |
|
D'oh, looks like |
Now is since march 2024 by a person you might know well 😄 |
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Thank you.
|
Oh, but please squash before merging! |
2f8a965 to
f17e4af
Compare
Very true! Let me squash these commits... |
mbien
left a comment
There was a problem hiding this comment.
thanks for keeping toml support up2date!
| OpenIDE-Module: org.netbeans.libs.tomljava/3 | ||
| OpenIDE-Module: org.netbeans.libs.tomljava/5 | ||
| OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/tomljava/Bundle.properties | ||
| OpenIDE-Module-Specification-Version: 1.8 | ||
| OpenIDE-Module-Specification-Version: 4.0 |
There was a problem hiding this comment.
someone might be looking at this PR for reference in future during updates and wonder why some versions were skipped. Are those numbers synced to components of the lib version or something like that?
There was a problem hiding this comment.
Does look a little odd, but also reminds me, I think we should keep adding implementation versions for libraries, such as at https://github.com/apache/netbeans/blob/master/platform/libs.flatlaf/manifest.mf#L7
eg. here
OpenIDE-Module-Implementation-Version: 13.5.1
|
noticed while testing that toml has no new-file template, added it via #9244 |
|
@vieiro thanks for the update! |
This bumps library version in
ide/libs.tomljavato v13.5.1, which adds support for the TOML v1.1 specification (which was added by Matthias here).NOTE: v13.5.1 was published a while ago, still no visible in search.maven.org, though. May take some time to propagate.