Skip to content

Bump toml-java to 13.5.1 for TOMLv1.1#9242

Merged
vieiro merged 1 commit intoapache:masterfrom
vieiro:feature/toml-java-version-bump
Mar 4, 2026
Merged

Bump toml-java to 13.5.1 for TOMLv1.1#9242
vieiro merged 1 commit intoapache:masterfrom
vieiro:feature/toml-java-version-bump

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Mar 2, 2026

This bumps library version in ide/libs.tomljava to v13.5.1, which adds support for the TOML v1.1 specification (which was added by Matthias here).

NOTE: v13.5.1 was published a while ago, still no visible in search.maven.org, though. May take some time to propagate.

@vieiro vieiro requested a review from matthiasblaesing March 2, 2026 22:22
@vieiro
Copy link
Contributor Author

vieiro commented Mar 2, 2026

D'oh, looks like I should be adding some label or something, as the old version is still being used (caching?)

2026-03-02T22:25:44.2930451Z /home/runner/work/netbeans/netbeans/nbbuild/build.xml:676: The following error occurred while executing this line:
2026-03-02T22:25:44.2931402Z /home/runner/work/netbeans/netbeans/nbbuild/templates/projectized.xml:314: Could not find file /home/runner/work/netbeans/netbeans/ide/libs.tomljava/external/toml-java-13.4.2.jar to copy
2026-03-02T22:25:44.2932155Z 
2026-03-02T22:25:44.2932262Z Total time: 1 minute 58 seconds
2026-03-02T22:25:44.3300272Z ##[error]Process completed with exit code 1.
2026-03-02T22:25:44.3421323Z Post job cleanup.

@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label Mar 3, 2026
@mbien
Copy link
Member

mbien commented Mar 3, 2026

... old version is still being used (caching?)

you have to update the project.properties and project.xml of the same module too. A search&replace on the module folder usually catches everything.

edit:

NOTE: v13.5.1 was published a while ago, still no visible in search.maven.org, though. May take some time to propagate.

all good its there: https://repo1.maven.org/maven2/net/vieiro/toml-java/13.5.1/

@vieiro
Copy link
Contributor Author

vieiro commented Mar 3, 2026

... old version is still being used (caching?)

you have to update the project.properties and project.xml of the same module too. A search&replace on the module folder usually catches everything.

Ah, very true! Thanks, @mbien !

@vieiro vieiro marked this pull request as draft March 3, 2026 09:33
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Mar 3, 2026
@mbien mbien added this to the NB30 milestone Mar 3, 2026
@matthiasblaesing
Copy link
Contributor

@vieiro thanks for the update. I integrated the released version into my experimental rust-analyser branch (bumping from my personal toml-java build). The update branch can be found here:

The branch can be found here: https://github.com/matthiasblaesing/netbeans/tree/rust-analyser

The commit integrating the updated toml-java is here: 3a8d890

In addition to updating the binary it also bumps the major version of the module as the API was broken (see required sigfile update).

To expand the info from @mbien: The binaries-list file only causes an external file to be downloaded for the built. It does describe what happens with it. For example the downloaded file could be a built-time only dependency (compiler, reference jars, ...). The bundling process then also has multiple levels: the downloaded file could be just bundled (that is the entry in the project.properties) or it can also be pulled onto the classpath of the module (that is the change in the project.xml and if it is pulled onto the classpath, it can also be expose and API and that might be exported. Exported API is subject to change/compatibility tracking manifesting in the signature files and the versions of the module.

@vieiro vieiro marked this pull request as ready for review March 3, 2026 18:08
@vieiro
Copy link
Contributor Author

vieiro commented Mar 3, 2026

@vieiro thanks for the update. I integrated the released version into my experimental rust-analyser branch (bumping from my personal toml-java build). The update branch can be found here:

The branch can be found here: https://github.com/matthiasblaesing/netbeans/tree/rust-analyser

The commit integrating the updated toml-java is here: 3a8d890

In addition to updating the binary it also bumps the major version of the module as the API was broken (see required sigfile update).

To expand the info from @mbien: The binaries-list file only causes an external file to be downloaded for the built. It does describe what happens with it. For example the downloaded file could be a built-time only dependency (compiler, reference jars, ...). The bundling process then also has multiple levels: the downloaded file could be just bundled (that is the entry in the project.properties) or it can also be pulled onto the classpath of the module (that is the change in the project.xml and if it is pulled onto the classpath, it can also be expose and API and that might be exported. Exported API is subject to change/compatibility tracking manifesting in the signature files and the versions of the module.

Thanks @matthiasblaesing .
It took me a while to remember everything and find out the ant gen-sigtest target. I hope this last commit makes the testing pass.

@vieiro
Copy link
Contributor Author

vieiro commented Mar 3, 2026

D'oh!, forgot to update the version of the module. Will do that.

@vieiro
Copy link
Contributor Author

vieiro commented Mar 3, 2026

D'oh, looks like ide/languages.toml is dependent on libs.tomljava now...

@matthiasblaesing
Copy link
Contributor

matthiasblaesing commented Mar 3, 2026

D'oh, looks like ide/languages.toml is dependent on libs.tomljava now...

Now is since march 2024 by a person you might know well 😄

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you.

@matthiasblaesing
Copy link
Contributor

Oh, but please squash before merging!

@vieiro vieiro force-pushed the feature/toml-java-version-bump branch from 2f8a965 to f17e4af Compare March 4, 2026 07:17
@vieiro
Copy link
Contributor Author

vieiro commented Mar 4, 2026

Oh, but please squash before merging!

Very true! Let me squash these commits...

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for keeping toml support up2date!

Comment on lines -2 to +4
OpenIDE-Module: org.netbeans.libs.tomljava/3
OpenIDE-Module: org.netbeans.libs.tomljava/5
OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/tomljava/Bundle.properties
OpenIDE-Module-Specification-Version: 1.8
OpenIDE-Module-Specification-Version: 4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone might be looking at this PR for reference in future during updates and wonder why some versions were skipped. Are those numbers synced to components of the lib version or something like that?

Copy link
Member

@neilcsmith-net neilcsmith-net Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does look a little odd, but also reminds me, I think we should keep adding implementation versions for libraries, such as at https://github.com/apache/netbeans/blob/master/platform/libs.flatlaf/manifest.mf#L7

eg. here

OpenIDE-Module-Implementation-Version: 13.5.1

@mbien
Copy link
Member

mbien commented Mar 4, 2026

noticed while testing that toml has no new-file template, added it via #9244

@vieiro vieiro merged commit 52347ee into apache:master Mar 4, 2026
30 checks passed
@matthiasblaesing
Copy link
Contributor

@vieiro thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Upgrade Library Library (Dependency) Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants