Remove DaemonNamedLockFactoryAdapterFactoryImpl#1556
Open
Conversation
This class existed to override Maven Resolver's default named lock factory and name mapper to file-lock + file-gav. Since resolver 2.0.0, these are already the defaults, making this override a no-op. Removing it eliminates the dependency on resolver internal classes (org.eclipse.aether.internal.impl.synccontext.named.*), which broke when the constructor signature changed in resolver 2.0.14. This unblocks upgrading maven-resolver-impl (PR #1538). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DaemonNamedLockFactoryAdapterFactoryImplwhich overrode Maven Resolver's default named lock factory (file-lock) and name mapper (file-gav). Since resolver 2.0.0, these are already the defaults, making this class a no-op.org.eclipse.aether.internal.impl.synccontext.named.*), which broke when the constructor signature changed in resolver 2.0.14 (newLockingInhibitorFactoryparameter).Context
The class was introduced in MNG-7586 when mvnd used resolver 1.9.2, which defaulted to
rwlock-local+gav. The override tofile-lock+file-gavwas necessary then but became redundant when resolver 2.0.0 adopted the same defaults.Test plan
mvnw verify -DskipTests)file-lock+file-gavby default🤖 Generated with Claude Code