[QDP] Add unit tests for streaming amplitude encoder coverage#1200
Open
0lai0 wants to merge 2 commits intoapache:mainfrom
Open
[QDP] Add unit tests for streaming amplitude encoder coverage#12000lai0 wants to merge 2 commits intoapache:mainfrom
0lai0 wants to merge 2 commits intoapache:mainfrom
Conversation
0lai0
changed the title
ryankert01
force-pushed
the
test_amplitude
branch
from
e3a7557 to
0a4e6fd
Compare
guan404ming
force-pushed
the
test_amplitude
branch
from
0a4e6fd to
b58616a
Compare
Member
|
Hi @0lai0, I think there is some issue in rebasing process on Github which causing the commit error. Could you please commit again with your account, thanks! |
Contributor
Author
|
Sure, should I close this PR? |
Contributor
Author
|
Thanks for catching that! I found this issue was my git config had an invalid email format (0lai0 instead of a proper email address), which caused the commit author info to appear broken after rebasing. I've fixed my git config and re-committed with --amend --reset-author. The force push should now show the correct author. Sorry for the trouble! |
Contributor
Author
|
If this still broken I would commit again |
Member
|
It works now. THanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1180
Changes
Why
encoding/amplitude.rshad less code coverage. This means there was no regression protection for sample size validation, state initialization, or the streaming encoding path.How
Added 6 unit tests in
qdp/qdp-core/src/encoding/amplitude.rs:reject_sample_size_zero
— validates sample_size == 0 returns InvalidInput
reject_sample_size_exceeds_stage
— validates sample_size > STAGE_SIZE_ELEMENTS returns InvalidInput
accept_valid_sample_size
— confirms valid size passes
accept_max_valid_sample_size
— boundary test at STAGE_SIZE_ELEMENTS
needs_staging_copy_returns_true
— verifies default trait impl
init_state_allocates_norm_buffer
— confirms GPU norm buffer allocation succeeds
Checklist