Fix typo: AGGREGRATE_TIME_LIST → AGGREGATE_TIME_LIST#17171
Fix typo: AGGREGRATE_TIME_LIST → AGGREGATE_TIME_LIST#17171PDGGK wants to merge 2 commits intoapache:masterfrom
Conversation
Fixes apache#17155 - AbstractCli.java: Rename constant from AGGREGRATE_TIME_LIST to AGGREGATE_TIME_LIST - Cli.java: Update all references to use correct spelling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a spelling typo in a constant name, changing AGGREGRATE_TIME_LIST to AGGREGATE_TIME_LIST throughout the CLI codebase. The typo was correctly identified in issue #17155, and this change ensures the constant name properly reflects its purpose of storing time aggregation operations.
Changes:
- Renamed the constant from
AGGREGRATE_TIME_LISTtoAGGREGATE_TIME_LIST(fixing the misspelling of "aggregate") - Updated all usages of the constant in the codebase
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AbstractCli.java | Renamed the constant definition from AGGREGRATE_TIME_LIST to AGGREGATE_TIME_LIST |
| Cli.java | Updated both references (lines 188, 203) to use the corrected constant name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| static final int CODE_ERROR = 1; | ||
|
|
||
| static final String ISO8601_ARGS = "disableISO8601"; | ||
| static final List<String> AGGREGRATE_TIME_LIST = new ArrayList<>(); |
There was a problem hiding this comment.
Looks like this list is useless. Better to remove it?
|
Good catch! You're right - I checked and this list is only written to but never read anywhere. It's dead code. I'll update this PR to remove the variable entirely instead of just fixing the typo. Thanks for the review! |
Per review feedback from @HTHou: this list is only written to but never read anywhere in the codebase - it's dead code. Removing it entirely instead of just fixing the typo. Fixes apache#17155
Summary
Fix typo in constant name:
AGGREGRATE_TIME_LIST→AGGREGATE_TIME_LISTFixes #17155
Changes
AbstractCli.java: Rename constant fromAGGREGRATE_TIME_LISTtoAGGREGATE_TIME_LISTCli.java: Update all references (lines 188, 203) to use correct spellingNotes
🤖 Generated with Claude Code