Skip to content

Conversation

@proost
Copy link
Member

@proost proost commented Feb 13, 2026

we should throw exception when k is negative.

@proost proost self-assigned this Feb 13, 2026
@jmalkin
Copy link
Contributor

jmalkin commented Feb 13, 2026

How does an unsigned int go negative?

@proost
Copy link
Member Author

proost commented Feb 13, 2026

@jmalkin
I'm sorry, i missed type in signature during comparing to java code.

@proost proost closed this Feb 13, 2026
@proost proost deleted the fix-wrong-k-condition-check branch February 13, 2026 04:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 21974449693

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.808%

Totals Coverage Status
Change from base Build 21916904519: 0.0%
Covered Lines: 17247
Relevant Lines: 17455

💛 - Coveralls

@jmalkin
Copy link
Contributor

jmalkin commented Feb 13, 2026

It happens to everyone at times :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants