Fix duplicate RUNNING_VM helper record creation on repeated VM.START events#12606
Open
SURYAS1306 wants to merge 1 commit intoapache:mainfrom
Open
Fix duplicate RUNNING_VM helper record creation on repeated VM.START events#12606SURYAS1306 wants to merge 1 commit intoapache:mainfrom
SURYAS1306 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Repeated
VM.STARTevents for the same VM could result in duplicateRUNNING_VMhelper usage records being created in the usage database.This PR adds a defensive check in
UsageManagerImpl#createVMHelperEventto detect an existing active
RUNNING_VMusage record (same VM instance,endDate = NULL) and skip helper record creation when a duplicate STARTevent is received.
A regression test has been added to ensure that duplicate
RUNNING_VMhelper records are not created when repeated
VM.STARTevents areprocessed.
Fixes: #12590
Expected behavior
Only one active
RUNNING_VMusage helper record should exist per VM atany given time.
Actual behavior
Multiple
RUNNING_VMhelper records could be created for the same VMwhen duplicate
VM.STARTevents were processed.Types of changes
Bug Severity
How Has This Been Tested?
UsageManagerImplTestto verify that duplicateRUNNING_VMhelper records are not created when repeatedVM.STARTevents are handled.
cloud-usagemodule successfully using Maven.How did you try to break this feature and the system with this change?
VM.STARTevents for the same VM instance to ensurethat helper record creation is skipped when an active
RUNNING_VMrecord already exists.