CASSANDRA-21237 Fix clustering keys order in KeyLookupBench#4683
Open
k-rus wants to merge 1 commit intoapache:trunkfrom
Open
CASSANDRA-21237 Fix clustering keys order in KeyLookupBench#4683k-rus wants to merge 1 commit intoapache:trunkfrom
k-rus wants to merge 1 commit intoapache:trunkfrom
Conversation
Generating clustering keys per partition in lexicographical order, since sorting primary keys afterwords is not enough. Also fixes the condition for starting new partition. Both fixes were needed to solve the "IllegalArgumentException: Clustering keys must be in ascending lexographical order". Ordering clustering key is implemented through a helper inner class, so the generated strings can be sorted before making keys. Also: - Fixes to use decomposeUntyped - Fixes formatting with missing spaces
Contributor
Author
|
Java 11 CI build: http://ci-cassandra.infra.datastax.com/job/cassandra/90/ Builds succeeded except few unrelated test failures. The benchmark is not port CI build, so the CI builds confirm that there is no compilation errors only. I don't know how KeyLookupBench can be tested, except running locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating clustering keys per partition in lexicographical order, since sorting primary keys afterwords is not enough. Also fixes the condition for starting new partition. Both fixes were needed to solve the "IllegalArgumentException: Clustering keys must be in ascending lexographical order".
Ordering clustering key is implemented through a helper inner class, so the generated strings can be sorted before making keys.
Also:
Hopefully this changes are not disturbing.
patch by Ruslan Fomkin; reviewed by for CASSANDRA-21237